You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR was just an example on how to implement the validation, as in added via +kubebuilder:validation and then tested with testenv. We need to review each CRD for all controllers, and make sure that all fields are validated.
OK
The validation will depend on each field at hand, so may need some research on how that field is being used, and what rules it has to abide by.
Those reference types at the moment only have +required, they lack max length and pattern validation. In some CRD we may be using other types instead of them to refer to Kubernetes objects, when that's the case we must change that.
@Santosh1176 unfortunately this will be on a case-by-case basis. Feel free to propose some validation for one of the CRDs and during the review we will provide you with some feedback.
In the run-up to maturing flux APIs, we should review all CRD validation and ensure that they align with expected input.
Controllers:
Additional points to consider:
.Spec
fields should be marked as required across all CRDs.The text was updated successfully, but these errors were encountered: