Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt when overriding a Helm-managed Flux installation #4342

Closed
stefanprodan opened this issue Oct 19, 2023 · 0 comments · Fixed by #4355
Closed

Add prompt when overriding a Helm-managed Flux installation #4342

stefanprodan opened this issue Oct 19, 2023 · 0 comments · Fixed by #4355
Assignees
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests area/ux In pursuit of a delightful user experience

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Oct 19, 2023

When running flux bootstrap or flux install we should detect if Flux is already installed on the cluster with Helm.

We can look for the app.kubernetes.io/managed-by label on the gitrepositories.source.toolkit.fluxcd.io CRD. If the CRD exists and has this label, and if the value is set to Helm or any other manager besides Flux, we should prompt like so:

Flux <VERSION> has been installed on this cluster with <MANAGER>!
Are you sure you want to proceed with overriding the <MANAGER> installation? Y/N

The Flux version should be extracted from the app.kubernetes.io/version label value.

Both flux bootstrap and flux install commands should have a --force flag, when set, this will bypass the above prompt.

@stefanprodan stefanprodan added area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests area/ux In pursuit of a delightful user experience labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests area/ux In pursuit of a delightful user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants