Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark events to prevent alerting spam #139

Closed
stefanprodan opened this issue Aug 3, 2021 · 1 comment
Closed

Mark events to prevent alerting spam #139

stefanprodan opened this issue Aug 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@stefanprodan
Copy link
Member

Taken from fluxcd/source-controller#411

To improve observability through events, without spamming the alerting system, I propose we introduce a new eventSeverity type called trace. The trace events are emitted as Kubernetes events under Normal, these events are dropped when forwarding to notification controller. Every source reconciliation should issue a single info event that contains the source URL and revision (later on we should consider adding the commit message too for GitRepositories).
@scottrigby scottrigby mentioned this issue Aug 3, 2021
Closed
5 tasks
@darkowlzz darkowlzz mentioned this issue Oct 18, 2021
Merged
@pjbgf pjbgf added the enhancement New feature or request label Mar 30, 2022
@stefanprodan
Copy link
Member Author

Implemented in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanprodan @pjbgf