Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics about internal operations during a reconciler run #657

Open
aryan9600 opened this issue Apr 6, 2022 · 3 comments
Open

Expose metrics about internal operations during a reconciler run #657

aryan9600 opened this issue Apr 6, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@aryan9600
Copy link
Member

At the moment, we only expose the readiness of the object and the duration of the reconciler run. It'd be helpful for both users and developers if we expose metrics about internal ops such as garbage collection, remote operations (git fetch, helm pull, etc). This would enable us to analyze and optimize the operations and give users a clearer picture of how the controller is working.

@aryan9600 aryan9600 added the enhancement New feature or request label Apr 6, 2022
@cwyl02
Copy link
Contributor

cwyl02 commented Aug 3, 2022

hi @aryan9600, I am interested to work on this if ok

@cwyl02
Copy link
Contributor

cwyl02 commented Sep 8, 2022

hi @aryan9600 finally get some time to look deeper into this. And I see we have a cacheRecorder. Should we try to reuse that pattern where it fits?
Also, I guess for every metric we come up with, namespace is always a desirable dimension?

@aryan9600
Copy link
Member Author

Yes, using that pattern seems like a good idea for now, we can think about expanding the Recorder in fluxcd/pkg/runtime/metrics later.
I'd say the namespace and name labels are desirable for all metrics. Developers and users should be able to see stuff like the avg. duration of git checkout or a helm pull for each source object, which would enable them to have a clearer picture of the controller's behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants