Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo/Undo System is broken #23

Closed
giannissc opened this issue Dec 21, 2021 · 3 comments
Closed

Redo/Undo System is broken #23

giannissc opened this issue Dec 21, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@giannissc
Copy link

Rnote does undo/redo does not work as expected. When I press Ctrl + Z i expect it to undo the last action however what it currently does is starts undoing sometimes from the beginning, sometimes it undoes the last few actions and them jumps to the beginnning. The behaviour is very erratic and not consistent every time. See videos below:

redo-undo.mp4
redo-undo-2.mp4
@giannissc
Copy link
Author

The lines in the document indicate the order things were drawn

@flxzt flxzt added the bug Something isn't working label Dec 29, 2021
@flxzt
Copy link
Owner

flxzt commented Jan 10, 2022

I believe it should behave better now, at least not as random anymore.
However as I mentioned in #27, the undo / redo currently only works as trash / untrash strokes, it does not have memory for resizing, translating or any other stroke operations. I'll keep the issue open for tracking to implement this feature ( probably as more state and methods in the chrono component ).

@flxzt
Copy link
Owner

flxzt commented May 1, 2022

with #149 it should now be fixed and behave like in other apps ( including selection modifications, duplicating, trashing strokes, etc.) , but I'll keep this open for until after the release, for feedback.

@flxzt flxzt closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants