Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Pen strokes not registered #28

Closed
giannissc opened this issue Dec 21, 2021 · 6 comments
Closed

Bug: Pen strokes not registered #28

giannissc opened this issue Dec 21, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@giannissc
Copy link

I have tested this both on Xournal++ and rnote and I have noticed that some of the pen strokes in rnote are not registered/ignored. Let me know I can be of any help on this one

@giannissc
Copy link
Author

giannissc commented Dec 24, 2021

A bit more information about this one…I have noticed that this only happens when I am really zoomed in into to the canvas. I couldn't reproduce this issue when I configured the canvas to fit the screen. Hope this helps!

EDIT: Actually I don't this the problem is the zoom level as I have been able to reproduce is at all zoom levels. The problem is when drawing small strokes (happened when I was writing up some tiny text)

@flxzt flxzt added the bug Something isn't working label Dec 29, 2021
@flxzt
Copy link
Owner

flxzt commented Dec 29, 2021

Could you enable the visual debugging (the "vd" button here:
Bildschirmfoto vom 2021-12-29 17-28-12
And tell if the stroke is registered at all, and if yes screenshot it. I have a suspicion that the strokes that are not registered have less than 4 input data points, so they can't form a cubic bezier curve so are not drawn at all. The fix would be to improve the algorithm to draw quadratic curves for remainding input data points == 3 and straight lines for == 2.

@defini-tiv
Copy link

And maybe dots for == 1?
I noticed this too and found it annoying in cirtan situations.
However i dont know if we would need a tool setting for it, becaus maybe it could be unwanted in some cases.

@giannissc
Copy link
Author

Yeah that indeed seems to be the issue. There either 1,2 points usuually that are not drawn

@flxzt
Copy link
Owner

flxzt commented Apr 14, 2022

It should be fixed now in main. All input elements are now drained into stroke segments (including dots, when only 1 element was registered), when finishing it.

@giannissc
Copy link
Author

I can confirm that it has been good for a while now! I will close.

Again thanks for you work on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants