-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more clarity on deb packages being build or runtime dependencies #24
Comments
From https://github.com/rubys/dockerfile-rails#add-a-packageenvironment-variablebuild-argument :
Is this what you are looking for? Did you just miss it, or do you have any suggestions on how to make it more clear?
If adding a '--dev' option would be of value, I have no objection. I'm about to merge in the following change rails/rails#47594 which would obviously need to only apply to production. I'd also drop the setting of |
oh I'm sorry, looks like I had it before my eyes. On the other hand, maybe the fact that it was not immediately readable for me means that we should add an example here, even the one I gave, where in build we need Regarding |
Care to make a pull request? I'd like to keep the front page compact, but anything is fair game on additional pages.
At the moment, quite different use cases. dockerfile-rails assumes that you have an application. docked assumes that you have nothing and want to run |
Gotcha, will do, probably just one phrase.
Not necessarily, but I get your point. These commands from
this is the "overlap" I meant |
Hey folks, I just wanted to leave a small bit of feedback to this issue. I was using this project today for an app that leverages SQL Server, and therefor needs freetds-dev to build. The example @januszm left in the README was extremely valuable today, and I just wanted to thank you for adding it, and @rubys for allowing it in such prime real estate. In addition to helping configure the output, it helps highlight the difference between build and runtime binary deps. A lot of context in such a small example. (Particularly useful that it's the exact example I was trying to add ;)) |
Consider adding a new option or more information in README about installing deb packages needed for gem compilation and those needed for runtime.
It's about a situation when the app needs a gem for Postgresql, MySQL and MSSQL server to work (as well as GEOS for geospatial extensions). In this case, simply using the -add option does not help, and you have to assign different packages in the section:
than the packages needed here:
Apparently
--add
only adds packages required to build gems.I am also curious if this tool is to be used to create Docker images for development or is it intended to be only for building production images? I'm asking because here is hardcoded RAILS_ENV production
The text was updated successfully, but these errors were encountered: