Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs 21.11 is missing an important coreutils patch #24

Closed
jsierles opened this issue Mar 2, 2022 · 2 comments
Closed

nixpkgs 21.11 is missing an important coreutils patch #24

jsierles opened this issue Mar 2, 2022 · 2 comments
Labels
question Further information is requested

Comments

@jsierles
Copy link
Contributor

jsierles commented Mar 2, 2022

Some common gems like rbtrace will fail to compile on arm64-darwin without this coreutils patch:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/misc/coreutils/fix-arm64-macos.patch

So we should probably track unstable for now, perhaps?

@jsierles jsierles added the question Further information is requested label Mar 2, 2022
@samueldr
Copy link
Collaborator

samueldr commented Mar 2, 2022

We can.

I chose the stable release (21.11) as a way to explcitly show we are free to pick anything, including something where major version changes don't happen.

But since we're pinning to specific commits, we won't get surprised by software update. As long as the proper test infra and procedures are there to validate updates, it should be good.

The "unstable" in the name of the release is a bit misleading. Actual unstability is excessively rare. Previously I half-jokedly would have said it's the version numbers that are unstable, not the software. These days I say it should be named nixos-rolling rather than nixos-unstable.

So if you're fine with rolling releases, unstable is fine. And since we're doing due diligence and pinning a known good release, I wouldn't expect this to bite you at any point in time.

@jsierles
Copy link
Contributor Author

jsierles commented Mar 3, 2022

I just pinned to the top of unstable but I assume that's what you meant by a 'known good release'. Like you say, as long as pinning is overall a good choice for us, we're good. But this raises a doubt about how we might go about managing pins. I'll post in another issue.

@jsierles jsierles closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants