New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: registration decal setting #6099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat, just one potential freeze issue (which occured to me because the game didn't set the registration although it was set...).
flybywire-aircraft-a320-neo/html_ui/Pages/VLivery/Liveries/A32NX_Registration/Registration.html
Outdated
Show resolved
Hide resolved
flybywire-aircraft-a320-neo/html_ui/Pages/VLivery/Liveries/A32NX_Registration/Registration.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Saschl <19493808+Saschl@users.noreply.github.com>
Co-authored-by: Saschl <19493808+Saschl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Assurance Tester Report Testing Process:
Negatives: - Testing Results: Passed Hope this helps :-) |
Quality Assurance Tester Report Discord: Cdr_Maverick#6475 Testing Process: Negatives: none Testing Results: passed Works as expected. PS: Doesn't do anything of course for liveries where this is already deactivated. :) |
The intent is that liveries should not need to ship a panel.cfg, so they don't break each time we change that. ;) |
@tracernz That is something that should be communicated in the documentation for livery creation. |
Quality Assurance Tester Report Discord:john P Maguire#9027 Testing Process: Spawned A32NX on RW at EGJJ Negatives: Nothing observed. Testing Results: Passed Media: |
Fixes #[issue_no]
Summary of Changes
Add an option to the EFB to disable the dynamic registration decal on the fuselage. The decal is generally not desirable for real world liveries that have a painted registration.
When reviewing, check the feat commit. The earlier ones are importing the Asobo files as-is, and reformatting them.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Check that decal appears and disappears with the setting. Disable, then load a default aircraft and check it's unaffected.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.