Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: registration decal setting #6099

Merged
merged 6 commits into from Nov 2, 2021
Merged

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

Add an option to the EFB to disable the dynamic registration decal on the fuselage. The decal is generally not desirable for real world liveries that have a painted registration.

When reviewing, check the feat commit. The earlier ones are importing the Asobo files as-is, and reformatting them.

Screenshots (if necessary)

image
image
image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Check that decal appears and disappears with the setting. Disable, then load a default aircraft and check it's unaffected.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@tracernz tracernz added this to the v0.8.0 milestone Oct 29, 2021
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Oct 29, 2021
Copy link
Member

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat, just one potential freeze issue (which occured to me because the game didn't set the registration although it was set...).

Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🔴 Code Review: In progress Oct 29, 2021
tracernz and others added 5 commits October 30, 2021 02:24
Co-authored-by: Saschl <19493808+Saschl@users.noreply.github.com>
Co-authored-by: Saschl <19493808+Saschl@users.noreply.github.com>
Copy link
Member

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Quality Assurance automation moved this from 🔴 Code Review: In progress to 🟣 QA Team Review: Ready to Test Oct 29, 2021
@marcman86
Copy link
Contributor

Quality Assurance Tester Report
Discord:marcman86#4907
Object of testing: #6099
Tier of Testing: 1
Date: 30/10/2021

Testing Process:

  • Spawned A32NX C&D at EDDP
  • Checked EFB > Tail number was disabled by default
  • Enabled tail number > shows number
  • Disabled tail number, spawned with the 747 > tail number was shown (uneffected from A32NX setting)

Negatives: -

Testing Results: Passed
Conclusions: Works for me

Hope this helps :-)

@frankkopp
Copy link
Member

Quality Assurance Tester Report

Discord: Cdr_Maverick#6475
Object of testing: #6099
Tier of Testing: 1
Date: 31.10.2021

Testing Process:
c&d at gate - just turning on flyPad - switching "enabled"/"disabled" and confirming in external view.

Negatives: none

Testing Results: passed

Works as expected.

PS: Doesn't do anything of course for liveries where this is already deactivated. :)

@tracernz
Copy link
Member Author

PS: Doesn't do anything of course for liveries where this is already deactivated. :)

The intent is that liveries should not need to ship a panel.cfg, so they don't break each time we change that. ;)

@bouveng
Copy link
Member

bouveng commented Oct 31, 2021

The intent is that liveries should not need to ship a panel.cfg, so they don't break each time we change that. ;)

@tracernz That is something that should be communicated in the documentation for livery creation.

@johnpmaguire
Copy link
Contributor

Quality Assurance Tester Report

Discord:john P Maguire#9027
Object of testing: #6099
Tier of Testing: 1
Date: 2/11/2021

Testing Process:

Spawned A32NX on RW at EGJJ
Checked EFB that DRD was disabled by default
Enabled DRD quit to main menu and changed the livery. DRD was again initialised as disabled.
Enabled DRD the work around black line to hide the registration was shown on the aircraft.

Negatives: Nothing observed.

Testing Results: Passed
Conclusions: LGTM and far better for livery makers.

Media:
Pic 1 DRD enabled. Black line is the covering graphic.
6099 enabled

PIC 2 DRD disabled lovely clean paintwork.
6099 disableed

@bouveng bouveng merged commit 4a363a3 into flybywiresim:master Nov 2, 2021
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants