New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GSX Integration #7695
feat: GSX Integration #7695
Conversation
- Got Boarding Synced - Need to sync cargo, and deboarding
- Cargo now loads in accordance with GSX - WIP Deboarding setup - Several checks in EFB and boarding backend to ensure state - Properly hide elements in EFB
Note: |
- Created 3rd Party Options Page - Support cargo and passenger deboarding - Added GSX Config - Bug fixes
…nx into feature/gsx-integration
- Changelog
flybywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/GSX.cfg
Outdated
Show resolved
Hide resolved
flybywire-aircraft-a320-neo/html_ui/Pages/A32NX_Core/A32NX_Boarding.js
Outdated
Show resolved
Hide resolved
Quality Assurance Trainee Report Discord : LeDerpLegend#0109 Testing Process: Followed instructions to set settings in the EFB, set payloads ahead of time, and followed down the checklist, using the EFB mainly as a input and visual reference, and GSX as the program in control. At the time of testing GSX is on Version 2.1.16 I did a small loop around flight around LAS, spawned at a gate, loaded simbrief, loaded with some fuel instantly, good. Reset the flight, this time using real time fuel to fill up, good. Loaded simbrief into into payload page, started boarding process with GSX. Seats and cargo filled up as intended, and editing any info was disabled until plane was empty. Fuel page was disabled as long as I was at a gate, if I was taxing or flying, I was able to edit my fuel with instant time. EFB x Simbrief
Payload
Negatives:
Positives:
Testing Result: Conclusion: Well done on this, honestly, it's something I've been looking forward to for a while. I think this could be cleaned up a bit in terms of UI and some instructions (like making sure to set Payload ahead of requesting boarding, or buttons becoming disabled.) Overall, good job. |
I have uploaded your flyPad translation keys to Localazy: "ThirdPartyOptions": {
"Title": "3rd Party Options",
"GsxFuelEnabled": "GSX Fueling Synchronization",
"GsxPayloadEnabled": "GSX Payload Synchronization"
}, |
Thanks for the test :) @LeDerpLegend
The aft service door does indeed work so that should work. You might need to manually open it in the EFB. Perhaps GSX is unaware of the simvar to do it on it's own. The aft cargo door cannot be opened and so that is disabled in accordance with the provided GSX profile So only one luggage car should arrive. Make sure you don't already have a custom profile.
This is interesting, couldn't get it to stop nagging on my end.
I'll be making documentation as-well. |
- Fix GSX parking brake test simvars - Refactored Boarding backend to be more readable - Added enums for GSX States in EFB and backend
This has to do with the front service door. The aft service door opens up as intended automatically, however the front one, visually at least, remains closed, but the catering truck still operates normally. Just some dude who has the power to phase through walls I guess. I know that the aft cargo door can not be opened, I should state that this issue seems to happen when arriving back at an airport, or restarting GSX's connection service. I can never remember how to spell it but something along the lines of Colgut or something. I have no custom profiles for the A320 or KLAS
It may have to do with some settings with GSX fueling. I set it to fuel at least for 5 seconds before disconnecting. I wonder if this changes anything. If you want I can send an image of my settings later. I have had no issues with it nagging me when attempting to defuel, it just plays the animation, fuels for a little bit (with audio, it doesn't change the fuel load in the plane whatsoever.) Then they pack up and leave like normal.
Very well. |
- Properly hide Simbrief Setter button
- Improved UI rendering instead of hiding components
I have no idea what you're asking for here. This is a PR for the A32NX, I no idea this'll work with Headwind, speak to the people there. |
- Fix a bug with simbrief button - Can no longer edit seat and cargo layout during boarding
- Fix parking brakes test
pushbackdummyevent = 0 | ||
pushbackcheckengines = 0 | ||
iscargo = 0 | ||
trafficcones = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should disable GSX cones as we have our own. What do you think?
Tried with experimental version, enabled 3rd party GSX things. Simbrief used. However the fuel truck always loads too slowly, even if i move the timings to x10. FBW is already done 5 mins ago, loading less than 3000kg of fuel. I always load real time. Tried this with progressive fueling and detect 3rd party fueling checked. For the passengers, the EFB of FBW has no buttons available, nothing also happens there and is basically dead. I assume they load.. |
- Remove forward service door.
Squashed commit of the following: commit c024ba7 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Wed Feb 1 11:12:02 2023 +0000 GSX Integration - Remove forward service door. commit 4c03bef Merge: ff70174 fa3b5e6 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Wed Feb 1 11:02:01 2023 +0000 Merge branch 'master' into feature/gsx-integration commit ff70174 Author: Alex McBean <al.mcbean@outlook.com> Date: Mon Jan 23 12:24:38 2023 +0000 GSX Integration - Fix parking brakes test commit 9117dde Author: Alex McBean <al.mcbean@outlook.com> Date: Sun Jan 22 14:36:08 2023 +0000 GSX Integration - Fix a bug with simbrief button - Can no longer edit seat and cargo layout during boarding commit f6292cc Merge: 5ddcf49 42ea491 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:48:37 2023 +0000 Merge branch 'master' into feature/gsx-integration commit 5ddcf49 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:46:00 2023 +0000 FFS commit d581851 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:45:10 2023 +0000 GSX Integration - Fix Changelog commit b13e3f2 Author: Alex McBean <al.mcbean@outlook.com> Date: Fri Jan 20 18:26:46 2023 +0000 GSX Integration - Improved UI rendering instead of hiding components commit c2e6ff5 Merge: f11b2b8 986fd65 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 17:32:35 2023 +0000 Merge branch 'master' into feature/gsx-integration commit f11b2b8 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 17:23:42 2023 +0000 GSX Integration - Properly hide Simbrief Setter button commit 3c420ef Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 14:35:04 2023 +0000 GSX Integration - Fix GSX parking brake test simvars - Refactored Boarding backend to be more readable - Added enums for GSX States in EFB and backend commit 3099825 Merge: 4a9583b dc81f48 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 18:44:01 2023 +0000 Merge remote-tracking branch 'origin/master' into feature/gsx-integration commit 4a9583b Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 18:04:56 2023 +0000 GSX Integration - Changelog commit fd18c42 Merge: c764914 0ae61a9 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 17:58:14 2023 +0000 Merge branch 'feature/gsx-integration' of github.com:flybywiresim/a32nx into feature/gsx-integration commit c764914 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 17:58:10 2023 +0000 GSX Integration - Created 3rd Party Options Page - Support cargo and passenger deboarding - Added GSX Config - Bug fixes commit 0ae61a9 Merge: 76f1882 5140532 Author: Frank Kopp <frank@familie-kopp.de> Date: Mon Jan 9 19:50:34 2023 +0100 Merge branch 'master' into feature/gsx-integration commit 76f1882 Author: Alex McBean <al.mcbean@outlook.com> Date: Sun Jan 8 15:45:41 2023 +0000 Cargo Loading Complete - Cargo now loads in accordance with GSX - WIP Deboarding setup - Several checks in EFB and boarding backend to ensure state - Properly hide elements in EFB commit 8911e7d Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 7 17:49:05 2023 +0000 Payload Syncing WIP - Got Boarding Synced - Need to sync cargo, and deboarding commit 218c772 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 7 14:40:02 2023 +0000 Fuel Sync - Integrated GSX Fueling with the in-built progressive refueling system
Squashed commit of the following: commit c024ba7 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Wed Feb 1 11:12:02 2023 +0000 GSX Integration - Remove forward service door. commit 4c03bef Merge: ff70174 fa3b5e6 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Wed Feb 1 11:02:01 2023 +0000 Merge branch 'master' into feature/gsx-integration commit ff70174 Author: Alex McBean <al.mcbean@outlook.com> Date: Mon Jan 23 12:24:38 2023 +0000 GSX Integration - Fix parking brakes test commit 9117dde Author: Alex McBean <al.mcbean@outlook.com> Date: Sun Jan 22 14:36:08 2023 +0000 GSX Integration - Fix a bug with simbrief button - Can no longer edit seat and cargo layout during boarding commit f6292cc Merge: 5ddcf49 42ea491 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:48:37 2023 +0000 Merge branch 'master' into feature/gsx-integration commit 5ddcf49 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:46:00 2023 +0000 FFS commit d581851 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 21 12:45:10 2023 +0000 GSX Integration - Fix Changelog commit b13e3f2 Author: Alex McBean <al.mcbean@outlook.com> Date: Fri Jan 20 18:26:46 2023 +0000 GSX Integration - Improved UI rendering instead of hiding components commit c2e6ff5 Merge: f11b2b8 986fd65 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 17:32:35 2023 +0000 Merge branch 'master' into feature/gsx-integration commit f11b2b8 Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 17:23:42 2023 +0000 GSX Integration - Properly hide Simbrief Setter button commit 3c420ef Author: Alex Mcbean <alex.mcbean@sainsburys.co.uk> Date: Tue Jan 17 14:35:04 2023 +0000 GSX Integration - Fix GSX parking brake test simvars - Refactored Boarding backend to be more readable - Added enums for GSX States in EFB and backend commit 3099825 Merge: 4a9583b dc81f48 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 18:44:01 2023 +0000 Merge remote-tracking branch 'origin/master' into feature/gsx-integration commit 4a9583b Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 18:04:56 2023 +0000 GSX Integration - Changelog commit fd18c42 Merge: c764914 0ae61a9 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 17:58:14 2023 +0000 Merge branch 'feature/gsx-integration' of github.com:flybywiresim/a32nx into feature/gsx-integration commit c764914 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 14 17:58:10 2023 +0000 GSX Integration - Created 3rd Party Options Page - Support cargo and passenger deboarding - Added GSX Config - Bug fixes commit 0ae61a9 Merge: 76f1882 5140532 Author: Frank Kopp <frank@familie-kopp.de> Date: Mon Jan 9 19:50:34 2023 +0100 Merge branch 'master' into feature/gsx-integration commit 76f1882 Author: Alex McBean <al.mcbean@outlook.com> Date: Sun Jan 8 15:45:41 2023 +0000 Cargo Loading Complete - Cargo now loads in accordance with GSX - WIP Deboarding setup - Several checks in EFB and boarding backend to ensure state - Properly hide elements in EFB commit 8911e7d Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 7 17:49:05 2023 +0000 Payload Syncing WIP - Got Boarding Synced - Need to sync cargo, and deboarding commit 218c772 Author: Alex McBean <al.mcbean@outlook.com> Date: Sat Jan 7 14:40:02 2023 +0000 Fuel Sync - Integrated GSX Fueling with the in-built progressive refueling system
Quality Assurance Trainee Report Discord : brewers_10#5706 Testing Process: Loaded into Stand 17B at KLAX for a flight to KSFO. Followed instructions to a tee: results below :) Ensure simbrief loading still performs as before in EFB - OK Fueling Payload Negatives: Testing Results: Conclusions: |
- disable A32NX's chocks and cones if GSX enabled
Summary of Changes
Integrates GSX features with the aircraft custom systems including refueling, boarding and cargo. De-Ice will come at a later stage when we simulate the usefull of de-ice on aircraft performance.
GSX Profile disables the rear cargo door and rear passenger door, and disables the option of the fuel menu opening. Doors were disabled as they can't currently be opened in-game. If you still want passengers/cargo to use these doors then you can re-enable them in the
Airplane Settings
menu on GSX.Documentation will follow suit.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): Lucky38i
Testing instructions
There's a few things to be aware of when using GSX Sync. PLEASE READ each of these carefully, documentation is planned for release.
3rd Party Options
. Inside there are two options to give you the freedom on what to sync with GSX. This activates the synchronisation. Without it GSX won't sync as expected. It's important to note various items and fields get disabled in the payload and fuel page with these options enabled.An aircraft profile is provided, you don't need to do anything GSX picks up on this
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.