-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: payload variations at boarding #7816
base: master
Are you sure you want to change the base?
Conversation
fixed 1st station not missing lugg created missing cargo for each station
added french translation missing
fix refresh hook debug
fine display of % change in chances for conn fl setup fix adding pax randomness fix maxPax and MaxCargo
deleted deltaTargetPaxCargo logic using setDeltaRatioCargo with neg random values
fix missing deltaPax on bags
fix average bag weight not working
recenter random PAX bag weight
separated tunings for missed / additional exclusion of cargo variation if average atypical behaviour when setting planned values
Check for conflicts with #7715 |
@Maverickwoe Just as information: #7715 has been closed on the first of April. |
@GeheimagentNr1 Hi. Yes, I was following the other PR and checked the compatibility with my changes. It requires an extensive rework as some concepts were changed on the page and I can't merge my changes easily. I will probably work again on it after my other PR on failures is closed. |
@@ -591,6 +591,7 @@ | |||
1. [MISC] Sync settings across instruments - @tracernz (Mike) | |||
1. [MCDU] Remove some settings from MCDU the are now in the FlyPad - @tracernz (Mike) | |||
1. [EFB] Persist sound and EFB settings correctly - @tracernz (Mike) | |||
1. [EFB] Random Pax and bags features - @Maverickwoe (Garoomf#4683) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move changelog to 0.12.
Fixes #7179
Summary of Changes
Independently of the desired payload set (pax and cargo), either on the flypad's page or through simbrief, when you start the boarding procedures, a few random things may happen depending on the 4 new settings added in the Realism page.
The features within those settings are: (represented for each setting under the notation x/x/x/x)
1/ Some checked in seats may not be filled (missed boarding) : 0%/1.5%/1.5%/25% per seat
2/ Some non checked-in may get occupied (surprise passenger) : 0%/0.5%/0.5%/5% per seat
3/ There is a chance (0%/0%/5%/0%) that a late connection occurs which changes the feature 1's chance to 10%
4/ There is a chance (0%/0%/2.5%/0%) that your plane is late allowing late connections to board which changes the feature 2's chance to 5%
5/ All boarded pax luggage is globally randomized using the average set on the payload page within 5Kg and 25Kg if this average is already within these limits.
To further the feeling of realism and force the pilots to wait for the end of the boarding to obtain a final payload sheet, all "desired" values on the left of the payload sheet as well as the white arrows of the 4 cargo stations will not hint any change until the very end of the boarding where they will move to what has been realized during boarding.
Note also that the desired seats will stay reserved until the end of the boarding where they will be freed
Screenshots (if necessary)
References
Discussions with pinatacolada#6700, pilot, for a tuning and behaviour that matches his experience.
Additional context
Discord username (if different from GitHub): Garoomf#4683
Testing instructions
As statistics goes, this test plan might be time consuming. Feel free to stop the data collection for each topic as soon as you are convinced.
In the Payload page of the flypad.
set passenger bag weight at 15Kg
Go in the Realism setting page of the flypad.
In setting 'Variation of Payload' select setting : None
Return to the Payload page of the flypad.
Set 1 PAX, start boarding with instant boarding time setting
Verify that no change occurs on the planned passengers, cargo, zfw and cargo stations's white arrows at the top of the page before and after clicking the boarding start button.
repeat operation with setting 87 PAX and 174 PAX.
In setting 'Variation of Payload' select setting : Typical
Set 1 PAX, start boarding with fast boarding time setting
Verify that no change occurs on the planned passengers, cargo, zfw and cargo stations's white arrows at the top of the page during the boarding.
Accelerate boarding with instant boarding time setting.
Note down the current passengers, cargo and ZFW.
repeat the operation several times to note the results
the average of the tests should be of 2 pax with variations
repeat the process again with setting 87 PAX where the average should be of 86 pax with variations
repeat the process again with setting 174 PAX where the average should be of 171 pax with variations
you should also observe a variation in the cargo total and cargo stations at the top compared to the initial white arrows
In setting 'Variation of Payload' select setting : Connecting Flights
Same procedure as "Typical" but observe that very rarely, the disruption of the payload is much bigger.
1 pax ->10 pax average with great variation
87 pax -> 83 pax average with great variation
174 pax -> 157 pax average with great variation
you should also observe a variation in the cargo total and cargo stations at the top compared to the initial white arrows
In setting 'Variation of Payload' select setting : Frequent
Return to the Payload page of the flypad.
Set 0 PAX, start boarding with instant boarding time setting
Verify that no change occurs on the planned passengers, cargo, zfw and cargo stations's white arrows at the top of the page before and after clicking the boarding start button.
Set 1 PAX, start boarding with fast boarding time setting
Verify that no change occurs on the planned passengers, cargo, zfw and cargo stations's white arrows at the top of the page during the boarding.
Accelerate boarding with instant boarding time setting.
Note down the current passengers, cargo and ZFW.
repeat the operation several times to note the results
the average of the tests should be of 8 pax with variations
repeat the process again with setting 87 PAX where the average should be of 69 pax
repeat the process again with setting 174 PAX where the average should be of 130 pax
you should also observe a variation in the cargo total and cargo stations at the top compared to the initial white arrows
Non regression tests:
Go in the payload page in the Flypad.
Verify that Simbrief payload import works as before and fills in "Passengers" "Cargo" automatically.
Set the per passenger bag weight at 20
Set the per passenger weight at 80
Set 100 pax manually, verify that cargo is 2000
verify that ZFW = 52500
verify that ZFWCG changes
Verify that the seat map fills in accordingly.
Verify that the top 4 cargo station have the white arrow at roughly 20%
Set 500 cargo manually, verify that pax does not change
verify that ZFW = 51000
verify that ZFWCG changes
Verify that the top 4 cargo station have the white arrow at roughly 5%
Set 47500 ZFW manually, verify that pax is 50
verify that cargo is 1000
Verify that the seat map fills in accordingly.
Verify that the top 4 cargo station have the white arrow at roughly 10%
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.