-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(efb): Restructured API files #7984
Conversation
cca9db2
to
832ef0a
Compare
CS/Contributor/Unofficial Test Report Discord : Alepouna🌙#9824 Testing Process:
Negatives:
Testing Results: Notes: |
This is most likely to be a PR issue with the API keys used. They need to be stored securely and should never be visible. Therefore testing might have to be done using a local build by someone of the FBW Team with access to those secrets instead. |
You shouldn't get this far if the API keys are not present. Instead the page just shows "insufficient env" or something to that effect. |
You don't because the check for the ENV variables only checks if they are not present at all. But as I can see in the build process in the Github Actions for the PR builds it is written but as an empty string. Therefore this happens. |
d67094b
to
dcd7178
Compare
Dev Team Test Report Object of testing: #7984 Testing Process: With client secret
Without client secret (empty string)
Negatives: Testing Results: |
Summary of Changes
This PR has changed the folder structure of the APIs used for the EFB (e.g. Navigraph) and bundles them together in a separate folder. The Navigraphs Authentication/Authorization has been outsourced into the new folder structure to make it reusable for new integrations across the EFB.
Additional context
This PR is part of the preparation for the PR #7702 .
In addition this is a part of the preceeding PR #7728 that caused problems for a few users. The rest of the PR will be redone and submitted in a new PR.
Discord username (if different from GitHub): Micah#3002
Testing instructions
Please test the following functions:
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.