fix(aoc): ATIS can now be auto printed again #8039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8033
Summary of Changes
AOC ATIS requests when formatted for the Printer will now be auto printed. They will also now show up as an unread message.
Crucially this was caused by a issue where the message lost its class functions when returned from a promise to JS.
The solution albeit not perfect is to reconstitute the message class in Typescript through a helper function.
The call to messageRead was removed as it made no sense because there was no guarantee that the message had been inserted into the message queue by the time the call to messageRead was executed. Simply inserting the message with the Confirmed property already set to true achieves the original purpose and saves code.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
The changes entirely restrict themselves to the AOC ATIS request function therefore testing is as simple as:
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.