Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aoc): ATIS can now be auto printed again #8039

Merged
merged 4 commits into from
Jul 15, 2023

Conversation

Maximilian-Reuter
Copy link
Member

@Maximilian-Reuter Maximilian-Reuter commented May 21, 2023

Fixes #8033

Summary of Changes

AOC ATIS requests when formatted for the Printer will now be auto printed. They will also now show up as an unread message.

Crucially this was caused by a issue where the message lost its class functions when returned from a promise to JS.
The solution albeit not perfect is to reconstitute the message class in Typescript through a helper function.

The call to messageRead was removed as it made no sense because there was no guarantee that the message had been inserted into the message queue by the time the call to messageRead was executed. Simply inserting the message with the Confirmed property already set to true achieves the original purpose and saves code.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

The changes entirely restrict themselves to the AOC ATIS request function therefore testing is as simple as:

  1. In EFB select a ATIS source
  2. find Airport with existing ATIS
  3. request ATIS and set format option to PRINTER
  4. After delay, printer should start printing the received atis
  5. No COMPANY MSG memo should appear and the message should be read in the Received Messages part of the AOC

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance May 21, 2023
@tracernz tracernz requested a review from svengcz May 24, 2023 19:51
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test May 25, 2023
@2hwk 2hwk added this to the 0.10.1 milestone May 25, 2023
@2hwk 2hwk modified the milestones: 0.10.1, v0.11.0 Jun 4, 2023
@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8039
Tier of Testing : 1
Date : 25/6/2023

Testing Process:

  • Spawn

  • Go to AOC ATIS, set format to PRINTER

  • Get ATIS from LTFM (VATSIM)

  • Check printer prints

Testing Results:
Passed

@Benjozork Benjozork enabled auto-merge (squash) July 15, 2023 15:28
@Benjozork Benjozork merged commit f261d15 into flybywiresim:master Jul 15, 2023
6 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

ATSU: ATIS Format For Printer Doesn't Print
4 participants