Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lg): nose gear park brake light #7787

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Feb 11, 2023

Fixes #[issue_no]

Summary of Changes

Remove the erroneous gear condition (which was also broken as the gear var loads 100, not 1), and move the template to a more appropriate location.

Screenshots (if necessary)

Microsoft.Flight.Simulator.2024.06.16.-.02.06.15.04.mp4

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Check that the red parking brake light on the front gear works as in the video above.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Saschl Saschl added this to the v0.10.0 milestone Apr 18, 2023
@tracernz tracernz modified the milestones: v0.10.0, v0.11.0 May 13, 2023
@tracernz tracernz modified the milestones: v0.11.0, v0.12.0 Oct 24, 2023
@tracernz
Copy link
Member Author

@tracernz tracernz marked this pull request as ready for review June 15, 2024 14:08
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Jun 15, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test Jun 15, 2024
@LunakisDev
Copy link

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #7787
Tier of Testing: 1
Date: 16/6/2024

Testing Process:

  1. Spawned at LGAV in C&D state
  2. Started the aircraft
  3. Verified that the red parking brake light on the front gear works as expected

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@tracernz tracernz merged commit 0cc0c71 into flybywiresim:master Jun 16, 2024
7 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants