New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cwl checker #1361
Add cwl checker #1361
Conversation
(let ((flycheck-cwl-schema-path "schema/CommonWorkflowLanguage.yml")) | ||
(flycheck-ert-should-syntax-check | ||
"language/cwl/cwl.cwl" 'cwl-mode | ||
'(6 5 error "the `inputBinding` field is not valid because value is a str, expected null or CommandLineBinding" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as there is only one expected error, do we really need to include all these files for testing? In other words, can you build a minimal test that triggers the same error?
Unfortunately, we can not reduce files in IMO it is difficult to remove other schema files. |
ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just a minor change to the Vagrantfile
Vagrantfile
Outdated
@@ -171,6 +172,9 @@ Vagrant.configure("2") do |config| | |||
typescript \ | |||
js-yaml | |||
|
|||
echo "Installing packages with pip..." | |||
pip install schema-salad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a --user
flag.
@tom-tan I just needed to find some time to run the test locally. Thank you for adding one, by the way. This is a good PR all around. Could you also add a line to |
Done! |
Great! Nice work 👏 , and sorry for the delay. |
Thank you for merging! |
This request adds a syntax checker for Common Workflow Language (CWL) that describes analysis workflows and tools.
Its syntax is defined as Semantic Annotations for Linked Avro Data (SALAD).
I added a syntax checker for CWL using
schema-salad-tool
(link to pip repository), which is a validator of SALAD format.To test the CWL checker, I copied the schema files for CWL from the repository of schema salad, which are licensed under Apache-2.
I guess it is harmless to include these files to this repository for this purpose because Apache-2 and GPL-3 are compatible.