Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Coq checker (closes GH-1692) #1697

Merged
merged 2 commits into from Feb 5, 2024

Conversation

cpitclaudel
Copy link
Member

This checker doesn't read options from _CoqProject, and it's much too slow to be generally useful (and all Emacs Coq users use PG)

@cpitclaudel
Copy link
Member Author

Let's make one last release with Coq and then merge this

@cpitclaudel cpitclaudel force-pushed the cpitclaudel_remove-coq-checker branch from 3fbe61a to d170907 Compare May 12, 2020 02:29
@cpitclaudel cpitclaudel linked an issue May 13, 2020 that may be closed by this pull request
1 task
@LukeXuan
Copy link

Some strange configuration leads me to this pull request, maybe it's time to finally merge it :)

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to this.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cpitclaudel
❌ bbatsov
You have signed the CLA already but the status is still pending? Let us recheck it.

@bbatsov bbatsov merged commit 9a0a8db into master Feb 5, 2024
13 of 18 checks passed
@bbatsov bbatsov deleted the cpitclaudel_remove-coq-checker branch February 5, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coq: read options from _CoqProject
5 participants