not_rescue_exception_spec.rb

require 'spec_helper'

module RailsBestPractices
  module Reviews
    describe NotRescueExceptionReview do
      let(:runner) { Core::Runner.new(reviews: NotRescueExceptionReview.new) }

      describe "not_rescue_exception" do
        it "should not rescue exception in method rescue with named var" do
          content =<<-EOF
          def my_method
            do_something
          rescue Exception => e
            logger.error e
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(1).errors
          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:3 - not rescue Exception"
        end

        it "should not rescue exception in method rescue without named var" do
          content =<<-EOF
          def my_method
            do_something
          rescue Exception
            logger.error $!
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(1).errors
          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:3 - not rescue Exception"
        end

        it "should not rescue exception in block rescue with named var" do
          content =<<-EOF
          def my_method
            begin
              do_something
            rescue Exception => e
              logger.error e
            end
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(1).errors
          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:4 - not rescue Exception"
        end

        it "should not rescue exception in block rescue without named var" do
          content =<<-EOF
          def my_method
            begin
              do_something
            rescue Exception
              logger.error $!
            end
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(1).errors
          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:4 - not rescue Exception"
        end

        it "should allow rescue implicit StandardError in block rescue without named var" do
          content =<<-EOF
          def my_method
            begin
              do_something
            rescue
              logger.error $!
            end
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(0).errors
        end

        it "should allow rescue explicit StandardError in block rescue without named var" do
          content =<<-EOF
          def my_method
            begin
              do_something
            rescue StandardError
              logger.error $!
            end
          end
          EOF
          runner.review('app/helpers/posts_helper.rb', content)
          runner.should have(0).errors
        end
      end
    end
  end
end