Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused helper method crashing rails_best_practices #335

Open
ReganRyanNZ opened this issue Sep 21, 2018 · 0 comments
Open

Unused helper method crashing rails_best_practices #335

ReganRyanNZ opened this issue Sep 21, 2018 · 0 comments

Comments

@ReganRyanNZ
Copy link

As the title says, an unused helper method was crashing the system.

I fixed it by monkey patching into /core/check.rb:347 and changing this like:

@except_methods + internal_except_methods

to

@except_methods.to_a + internal_except_methods

So if it's already an array nothing happens, otherwise it converts nil into an empty array, allowing the + method to function.

It would be good to put this into the actual code, instead of monkey patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant