Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data update: new iso-codes release #85

Closed
llimeht opened this issue Nov 10, 2021 · 0 comments · Fixed by #86
Closed

Data update: new iso-codes release #85

llimeht opened this issue Nov 10, 2021 · 0 comments · Fixed by #86

Comments

@llimeht
Copy link
Contributor

llimeht commented Nov 10, 2021

There's a new iso-codes package out now, with version 4.8.0 being uploaded to Debian.

https://salsa.debian.org/iso-codes-team/iso-codes

The current Python bindings look like they need some updates to match the new version of iso-codes; naïvely using them together has most tests pass with the following failures:

FAILED test_general.py::test_country_fuzzy_search - LookupError: england
FAILED test_general.py::test_subdivisions_directly_accessible - AssertionErro...
FAILED test_general.py::test_subdivisions_have_subdivision_as_parent - Attrib...
FAILED test_general.py::test_repr - assert None
FAILED test_general.py::test_lookup - LookupError: Could not find a record fo...

I've not investigated further to find out whether it's a matter of updating the test data to match data changes or more complicated changes in the data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant