Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat-request] configurable stepDelay/stepCount #50

Closed
rmobis opened this issue Dec 31, 2020 · 1 comment
Closed

[feat-request] configurable stepDelay/stepCount #50

rmobis opened this issue Dec 31, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@rmobis
Copy link

rmobis commented Dec 31, 2020

It would be nice to be able to customize stepDelay and/or stepCount (https://github.com/flyingpie/windows-terminal-quake/blob/master/windows-terminal-quake/Toggler.cs#L64-L65). The main motivation would be to lower the delay/increase the count, as that would provide a much smoother animation.

However, I did some research (stack overflow, mdsn) and Task.Delay probably wouldn't work for a much shorter delay (anything below 15ms would be moot).

If there's any interest, I could look for alternative solutions and probably even draft a PR. Let me know. =D

@flyingpie
Copy link
Owner

@rmobis Thank you for the feedback, this will be part of the next release.

Look for the "ToggleAnimationFrameTimeMs" setting:

{
	// How long each frame in the toggle animation takes in milliseconds.
	// The lower this value, the smoother the animation, though values lower than 15 are not supported and will result in a toggle taking more than the configured ToggleDurationMs.
	"ToggleAnimationFrameTimeMs": 25
}

@flyingpie flyingpie added the enhancement New feature or request label Jan 1, 2021
@flyingpie flyingpie added this to the v1.0 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants