Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run perl -c #2

Open
petere opened this issue Oct 8, 2012 · 3 comments
Open

don't run perl -c #2

petere opened this issue Oct 8, 2012 · 3 comments

Comments

@petere
Copy link

petere commented Oct 8, 2012

Running perl -c on unknown files is dangerous because it executes BEGIN blocks, which could contain arbitrary code.

This module is currently a security risk.

@illusori
Copy link
Member

This is a vulnerability common to the base Flymake, for clarity I've added a warning to the README about the issue, but the intent of this library is to provide additive behaviour over basic Flymake, rather than removing existing behaviour.

I do accept that it's a concern though, I think I'll look at providing a configuration option to control the running of "perl -c", I can default that to being disabled and place a note in the docs saying that if you need/want the base behaviour of Flymake you can enable it.

Sorry for the slow response, haven't had time to keep up with my open source projects this month, and thanks for the comments.

@petere
Copy link
Author

petere commented Nov 9, 2012

I'm sorry, I wasn't aware that the built-in flymake already does that. I will have to redirect my complaint there then. In the meantime, I think it would be a good idea to provide an option (possibly default), to only run perlcritic.

@gemmaro
Copy link
Contributor

gemmaro commented Mar 3, 2024

Now that #4 has been merged, it looks like this issue can be closed.

Since this plugin uses the new Flymake backend feature, perl -c no longer exists.
Users who need syntax checking with perl -c can use the functionality provided by the perl-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants