New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set atom support #29
Merged
Merged
Set atom support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titanous
requested changes
Nov 9, 2020
daeMOn63
force-pushed
the
list_atom_support
branch
from
November 12, 2020 10:39
6389384
to
cc3a596
Compare
@titanous Renamed List to Set, and also dropped the new ListConstraint, and managed to reuse the existing constraints on sets, which looks better and simpler. |
daeMOn63
force-pushed
the
list_atom_support
branch
from
November 23, 2020 09:17
51ed27d
to
6e45166
Compare
titanous
requested changes
Nov 23, 2020
Removed list constraint, in order to reuse the existing set constraints
updated parser to expose methods allowing to convert parsed types into their biscuit types
daeMOn63
force-pushed
the
list_atom_support
branch
from
November 24, 2020 09:22
246821f
to
46cdd17
Compare
titanous
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new
Set
type, allowing to define an Atom as a sequence of atom.