Named variables support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this replaces integer variables by strings, allowing more readable definitions. (ie: $0 become $username).
titanous
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this switches biscuit.Variable type from uint32 to string, allowing more readable variables. (ie:
$0can be replaced by$username).The variable names are stored in the global symbols table, and their internal value (on datalog side is set to the integer index from the symbol table. for example, given a symbol table containing
["a", "b"], defining a fact containing a new variable$cwill insert the "c" string in the table (so it contains["a", "b", "c"]) and set its internal value to2(sosymbols2] = "c").Tests have been fixed, and samples updated from the specification repository (modified by biscuit-auth/biscuit@828f4c3)