Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

containerinit should unregister services immediately on SIGTERM/SIGINT #3388

Closed
titanous opened this issue Sep 14, 2016 · 0 comments
Closed

containerinit should unregister services immediately on SIGTERM/SIGINT #3388

titanous opened this issue Sep 14, 2016 · 0 comments
Labels
complexity/easy component/host kind/bug

Comments

@titanous
Copy link
Contributor

Currently the discoverd heartbeaters are closed by containerinit after the process exits. This is incorrect, as it results in additional traffic being sent to the app as it shuts down, which can result in requests being dropped.

Instead, as soon as a SIGTERM/SIGINT is received, we should pull the registration.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
complexity/easy component/host kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titanous