This repository has been archived by the owner on Apr 30, 2020. It is now read-only.
Slider media fixes #196
Merged
Slider media fixes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two different images, one for the image time, one for the oembed type (poster image). Added reqired statements. Added a min 1 for the slides repeater
…owto instead Removed defaultImage field, added a howto file to explain how to proceed to add a default poster image for the video oembed
Removed translatableOptions defaultTitleText field, not used
emcarru
approved these changes
May 24, 2017
dgrdl
approved these changes
May 24, 2017
usingthesystem
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the opacity problem if only one slide : images were not showing up.
Not showing the blank title box if no title.
Refactored fields: removed the default image (which was meant for a default poster image for videos) and default title text that were not used and unnecessary for a base component.
Added a howto.md file.