Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3 locations #2458

Closed
wants to merge 0 commits into from
Closed

Support S3 locations #2458

wants to merge 0 commits into from

Conversation

JonLally
Copy link

@JonLally JonLally commented Aug 4, 2019

Support s3 locations by use of aws-java-sdk-s3.

Issue references: #1961 #1779

  • I'm not 100% sure of some of the changes I made, specifically the entry in the flyway-core pom for the maven bundle plugin.
  • I also had to explicitly specify 4.5.2 version of the httpclient from apache http components, it is a transitive dependency of aws-java-sdk-s3 and updating the order of the dependencies didn't matter as it took the version from google android always.
  • I'm unsure of the testing process, I've had to manually test this but if there is an automated suite I can contribute to I'd like to provide tests around this functionality.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@mack1040 mack1040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - we have needed this feature for a while

Copy link

@carlitos081 carlitos081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!!!

@KiruthikaSS
Copy link

Eager to know, when this feature will be released. Any Milestone planned? Plz let me know.

@juliahayward juliahayward added this to the Flyway 6.x milestone Jan 3, 2020
@MikielAgutu MikielAgutu modified the milestones: Flyway 6.x, Flyway 6.3 Jan 27, 2020
@juliahayward
Copy link
Contributor

Many thanks for the contribution (and welcome to the hall of fame!) We're looking at including this by 6.3 - including tests at our end and documentation changes.

@juliahayward juliahayward mentioned this pull request Feb 6, 2020
@juliahayward
Copy link
Contributor

Do have a look at #2664 - this came up with both AWS SDK 1.11 and 2.0. We would strongly prefer to use the v2 SDK (which requires some code changes, although they are pretty mechanical and I have done them) however that requires Java 8 - any thoughts?
.

@JonLally
Copy link
Author

Wasn't aware of the AWS SDK v2, would definitely agree with using it instead of 1.1.

@Lyeeedar Lyeeedar modified the milestones: Flyway 6.3, Flyway 7.x Feb 19, 2020
@Lyeeedar
Copy link
Contributor

Moving this to flyway 7.x as the v2 SDK requires upgrading flyway from java 7. See #2458 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants