nim CI doesn't actually test this package

[timotheecour]

same issue as tulayang/asyncmysql#5
either a test task needs to be defined or a tests folder needs to exist

[flyx]

Please give more information, I don't really understand the problem. Are you talking about this service which currently 502s? What is it? How is it relevant to NimYAML?

Also, there is a test task, nim tests. While the currently configured CI doesn't work for reasons that escape me, I don't actually need it since NimYAML is in maintenance mode and for the rare changes I make, executing the tests manually works well enough.

[timotheecour]

Please give more information

when nim CI runs, it tests select packages to avoid introducing regressions in nim pacakges when new commits are added to nim, including NimYAML pacakage, see https://github.com/nim-lang/Nim/blob/9eeb514dda08f1caadb0d8e01a8595d991530b52/testament/important_packages.nim#L95

pkg "yaml"

the default action is cmd = "nimble test" (see https://github.com/nim-lang/Nim/blob/9eeb514dda08f1caadb0d8e01a8595d991530b52/testament/important_packages.nim#L2)

this all seemed to work, giving false impression that NimYAML was being tested in nim CI, whereas in fact nim-lang/nimble#780 reveals this was not the case.

The simplest fix is to add a task test to this package (not nim tests), or we'll have to disable testing for NimYAML in nim CI.

Also, there is a test task, nim tests. While the currently configured CI doesn't work for reasons that escape me

that doesn't help as you can see by running the default test command (being run in nim CI) nimble test.

see https://github.com/nim-lang/nimble#tests for what's supported (as other packages do):
either a test task in yaml.nimble, or have a tests dir (not test) and make sure they're actually being tested when running nimble test

I don't actually need it since NimYAML is in maintenance mode and for the rare changes I make, executing the tests manually works well enough

that's not the only reason for testing in nim CI, the other important reason is to make sure new PR's in nim repo don't break nim ecosystem (including NimYAML, on which other nimble packages depend on), as explained in nim-lang/Nim#8638

[flyx]

Thanks for the explanation, fixed it.