Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider passing in an SSLContext when creating the httpx client #27

Closed
bdraco opened this issue Mar 19, 2023 · 0 comments · Fixed by home-assistant/core#121407
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bdraco
Copy link

bdraco commented Mar 19, 2023

We recently discovered httpx does not perform well without passing in an ssl context (home-assistant/core#89932)

see encode/httpx#2609 encode/httpx#838 (comment)

The shared helper will be updated for this issue as well so it can be used and passed the library

from homeassistant.helpers.httpx_client import get_async_client to get the shared client

from homeassistant.helpers.httpx_client import create_async_httpx_client to create a new one (if you need to recreate or need you own)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants