Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: create a copy of Unmigratable vault, then delete it after the test runs #204

Open
fmaclen opened this issue May 6, 2024 · 0 comments
Labels
SvelteKit Involves SvelteKit's code tech debt Tasks that aim to make the codebase more maintainable

Comments

@fmaclen
Copy link
Owner

fmaclen commented May 6, 2024

We have a corrupt Unmigratable.vault we use to test that when a vault isn't migratable an error is displayed to the user.
But when the test runs it modifies this Unmigratable vault causing a Git diff.

These vaults need to remain in the repo (can't add them to.gitignore) so a solution could be to create temporary copies of the files, run the test, and then during the test cleanup delete such files.

@fmaclen fmaclen added tech debt Tasks that aim to make the codebase more maintainable SvelteKit Involves SvelteKit's code labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SvelteKit Involves SvelteKit's code tech debt Tasks that aim to make the codebase more maintainable
Projects
None yet
Development

No branches or pull requests

1 participant