Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline docker images from docker tags to docker shasum #100

Closed
Tracked by #88
fmalmeida opened this issue Jul 26, 2023 · 1 comment · Fixed by #108
Closed
Tracked by #88

Update pipeline docker images from docker tags to docker shasum #100

fmalmeida opened this issue Jul 26, 2023 · 1 comment · Fixed by #108
Assignees
Labels
enhancement New feature or request

Comments

@fmalmeida
Copy link
Owner

This relates to changing the docker config so, it uses docker shasum instead of tags, meaning that we can ensure that the pipeline always runs with the exact version of the docker image.

Sometimes, a docker image using a tag, can be updated due to bug fixes as happened in #96 however, if already available in the user's system, nextflow will not try to download it again.

However, using docker shasum, we can ensure making the pipeline always use the exact version of the pushed image, thus, guaranteeing automatic update by nextflow if a bugfix is made, even if the same tag is already available, however, with a different shasum, it is not considered the same for the pipeline.

E.g.

form this

// container for python tools
    withLabel: 'python' {
      container = 'fmalmeida/bacannot:v3.2_pyenv'
    }
  • to this*
// container for python tools
    withLabel: 'python' {
      container = 'fmalmeida/bacannot@sha256:bc217d0033d2a553a6a389e9fa3fe4912d6d11c07954bfe8d138fcdbfa2d43ef'
    }
@fmalmeida fmalmeida mentioned this issue Jul 26, 2023
@fmalmeida fmalmeida changed the title Update pipeline docker images so that from docker tags to docker shasum Update pipeline docker images from docker tags to docker shasum Jul 27, 2023
@fmalmeida fmalmeida added the enhancement New feature or request label Sep 14, 2023
@fmalmeida fmalmeida self-assigned this Sep 14, 2023
@fmalmeida
Copy link
Owner Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Release v3.3
Awaiting triage
Development

Successfully merging a pull request may close this issue.

1 participant