Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to set a global resfinder species value for samples in YAML #33

Closed
fmalmeida opened this issue Nov 4, 2021 · 2 comments · Fixed by #40
Closed

possibility to set a global resfinder species value for samples in YAML #33

fmalmeida opened this issue Nov 4, 2021 · 2 comments · Fixed by #40
Labels
enhancement New feature or request

Comments

@fmalmeida
Copy link
Owner

Add the possibility to use the --resfinder_species parameter outside the YAML file to set a global value for all samples described in the YAML. Which can then be overwritten if a specific sample has another value for it in samplesheet.

It will work like this, for example:

--resfinder_species Klebsiella will set all samples from the YAML as Klebsiella.

However, if the samplesheet is like this:

samplesheet:
  - id: sample_1
    illumina:
      - sample_1/1.fastq
      - sample_1/2.fastq
    nanopore: sample_1/ont.fastq
    resfinder: Escherichia coli
  - id: sample_2
    assembly: sample_2/assembly.fasta
  - id: sample_3
    nanopore: sample_3/ont.fastq
    fast5: sample_3/fast5_pass

It will run sample 2 and 3 as the global value "Klebsiella" and sample 1 will be run as "Escherichia coli" since it overwrites the global definition by setting a value inside the YAML.

@fmalmeida
Copy link
Owner Author

This is now being tackled in branch https://github.com/fmalmeida/bacannot/tree/develop together with issue #31

@fmalmeida
Copy link
Owner Author

Solved in new version 3.0.

@fmalmeida fmalmeida linked a pull request Nov 17, 2021 that will close this issue
@fmalmeida fmalmeida unpinned this issue Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant