Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple containers, different versions, only one entry in Images tab #17

Closed
rasmuslp opened this issue Oct 30, 2020 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@rasmuslp
Copy link

Hi,

When I run two containers of the same image -- but different version ranges and include regexes -- only one entry shows in the Images tab. I would expect to see different updates available for the two containers.
NB: This might be the effect of #16 ?

However, what I would really like is a container based view. Which I believe makes sense, now that the include tags (and others) are specified per container.

@fmartinou
Copy link
Owner

Hi,

Definitely a bug :(

The expected behaviour is to get 1 entry for each unique couple image+tag.

Let me explain with this simple example:

version: '3'

services:
    nginx_1:
        image: nginx:1.9-alpine
        labels:
            - 'wud.tag.include=^[0-9]\d*\.[0-9]\d*-alpine$$'

    nginx_2:
        image: nginx:1.10-alpine
        labels:
            - 'wud.tag.include=^[0-9]\d*\.[0-9]\d*-alpine$$'

    nginx_3:
        image: nginx:1.10-alpine
        labels:
            - 'wud.tag.include=^[0-9]\d*\.[0-9]\d*-alpine$$'

So 3 nginx instances:

  • One 1.9 instance
  • Two 1.10 instances

I expect to see 2 entries in the images tab and to get 2 notifications:

  • 1.9 update
  • 1.10 update

Would it suit you?

@fmartinou fmartinou added the bug Something isn't working label Oct 31, 2020
@fmartinou fmartinou self-assigned this Oct 31, 2020
@rasmuslp
Copy link
Author

Thank you for the elaborate example. I believe that would work for my use case. Even though I use different wud.tag.include labels, I do so on containers running different tags.

However, given how WUD allows configuration, then why not also include the include/exclude labels as part of that uniqueness, so that it would be image+tag[+include/exclude]?

@fmartinou
Copy link
Owner

Yes, it should be possible to include the wud labels to compute the uniqueness.
I just don't have in mind any valid use case where I'd want to track identical (image+tag) images with different include/exclude labels. 🤔

Do you have an example to let me understand?

@rasmuslp
Copy link
Author

No. I tried, but I could only come up with contrived examples 🙃 I thought it would make sense, but atm. I can't really see a real world scenario, where where it would be relevant.

@fmartinou
Copy link
Owner

Anyway, I must fix the issue regarding uniqueness so... if it' not too complicated, I can include the labels as well.

@rasmuslp
Copy link
Author

Much appreciated :)

@fmartinou
Copy link
Owner

fmartinou commented Nov 2, 2020

Hi,

It's normally fixed with version 3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants