-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue #239
Queue #239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 98.44% 98.64% +0.20%
==========================================
Files 7 7
Lines 385 369 -16
Branches 39 39
==========================================
- Hits 379 364 -15
+ Misses 3 2 -1
Partials 3 3
Continue to review full report at Codecov.
|
Of course there is 🤦 . |
Ok, first time squashing and it seems I have squashed more that what I should. I will have to check how to fix it, my bad. |
Actually, the Files Changed section of the PR seems about right, but if I check the |
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 98.44% 98.65% +0.21%
==========================================
Files 7 7
Lines 385 372 -13
Branches 39 39
==========================================
- Hits 379 367 -12
+ Misses 3 2 -1
Partials 3 3
Continue to review full report at Codecov.
|
847b4ee
to
310e700
Compare
Fixed! |
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 98.44% 99.26% +0.81%
==========================================
Files 7 7
Lines 387 409 +22
Branches 39 58 +19
==========================================
+ Hits 381 406 +25
+ Misses 3 1 -2
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
Hey @alonfnt, sorry about the slow response. Could I ask you to make any commit to this branch, which will trigger the (recently working again CI) to run? |
@bwheelz36 done :) |
Previously a custom implementation of Queue was being used with the same exact functionality as the built-in queue library.
thank you! |
Browsing the code I've seen a custom implementation of Queue. Since there is a queue on the Standard Library, why not use it? it may be useful when doing threading? and there is less code to maintain.
If this is not the direction you want to take feel free to close this PR. I just did it because it seems like reinventing the wheel a bit.