Check bounds_transformation is correct type #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type + test coverage
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 7 7
Lines 385 387 +2
Branches 39 39
=======================================
+ Hits 379 381 +2
Misses 3 3
Partials 3 3
Continue to review full report at Codecov.
|
fmfn
requested changes
Jul 8, 2020
bayes_opt/bayesian_optimization.py
Outdated
| try: | ||
| self._bounds_transformer.initialize(self._space) | ||
| except (AttributeError, TypeError): | ||
| raise AssertionError('The transformer must be instance of' |
There was a problem hiding this comment.
Is AssertionError the right choice? Maybe TypeError instead?
There was a problem hiding this comment.
You are right! TypeError is a better fit. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick check following the 'don't ask for permission ask for forgiveness' motto to make sure that the bounds_transformer used can be called otherwise a clear exception message is shown.