Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on GCC 8.1.2 i386 #2835

Closed
glebm opened this issue Mar 26, 2022 · 2 comments
Closed

Build error on GCC 8.1.2 i386 #2835

glebm opened this issue Mar 26, 2022 · 2 comments

Comments

@glebm
Copy link
Contributor

glebm commented Mar 26, 2022

 [ 60%] Building CXX object _deps/libfmt-build/CMakeFiles/fmt.dir/src/os.cc.o
In file included from /home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/src/format.cc:8:0:
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format-inl.h: In instantiation of ‘constexpr bool fmt::v8::detail::basic_fp<F>::assign(Float) [with Float = long double; F = fmt::v8::detail::uint128_fallback]’:
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format-inl.h:216:69:   required from ‘constexpr fmt::v8::detail::basic_fp<F>::basic_fp(Float) [with Float = long double; F = fmt::v8::detail::uint128_fallback]’
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format-inl.h:2212:20:   required from ‘int fmt::v8::detail::format_float(T, int, fmt::v8::detail::float_specs, fmt::v8::detail::buffer<char>&) [with T = long double]’
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/src/format.cc:92:64:   required from here
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format-inl.h:238:9: error: no match for ‘operator+=’ (operand types are ‘fmt::v8::detail::uint128_fallback’ and ‘fmt::v8::detail::uint128_fallback’)
       f += static_cast<F>(implicit_bit);
       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format-inl.h:29:0,
                 from /home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/src/format.cc:8:
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format.h:367:22: note: candidate: constexpr void fmt::v8::detail::uint128_fallback::operator+=(uint64_t)
   FMT_CONSTEXPR void operator+=(uint64_t n) {
                      ^~~~~~~~
/home/runner/work/devilutionX/devilutionX/build/_deps/libfmt-src/include/fmt/format.h:367:22: note:   no known conversion for argument 1 from ‘fmt::v8::detail::uint128_fallback’ to ‘uint64_t {aka long long unsigned int}’

Similar to #2810 but the error is different

Full build log https://github.com/diasurgical/devilutionX/runs/5703028971?check_suite_focus=true

@vitaut
Copy link
Contributor

vitaut commented Mar 27, 2022

Fixed in 9693016. Thanks for reporting.

@vitaut vitaut closed this as completed Mar 27, 2022
@glebm
Copy link
Contributor Author

glebm commented Mar 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants