Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some weird code in ostream.h #2842

Closed
jcelerier opened this issue Mar 29, 2022 · 3 comments
Closed

Some weird code in ostream.h #2842

jcelerier opened this issue Mar 29, 2022 · 3 comments

Comments

@jcelerier
Copy link
Contributor

I was reading the code and noticed the following:

https://github.com/fmtlib/fmt/blob/master/include/fmt/ostream.h#L79

Introduced here:

768061c#diff-39be774d509c569b421ee9c510ad5f6d306f4a187ce4540b03c761d77a087b32L95

but maybe it's normal ?
@vitaut
Copy link
Contributor

vitaut commented Mar 29, 2022

Good catch! I think this statement can be removed since it's a noop and all the required logic resides in formatbuf itself. A PR would be welcome.

@jcelerier
Copy link
Contributor Author

Sure, doing that

@jcelerier
Copy link
Contributor Author

PR in #2843

@vitaut vitaut closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @jcelerier