Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC warnings #296

Closed
vitaut opened this issue Mar 18, 2016 · 2 comments
Closed

MSVC warnings #296

vitaut opened this issue Mar 18, 2016 · 2 comments

Comments

@vitaut
Copy link
Contributor

vitaut commented Mar 18, 2016

    12>C:\projects\cppformat\test\posix-mock-test.cc(490): warning C4273: '_create_locale': inconsistent dll linkage [C:\projects\cppformat\test\posix-mock-test.vcxproj]
         C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\locale.h(100): note: see previous definition of '_create_locale'
    12>C:\projects\cppformat\test\posix-mock-test.cc(494): warning C4273: '_free_locale': inconsistent dll linkage [C:\projects\cppformat\test\posix-mock-test.vcxproj]
         C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\locale.h(105): note: see previous definition of '_free_locale'
    12>C:\projects\cppformat\test\posix-mock-test.cc(498): warning C4273: '_strtod_l': inconsistent dll linkage [C:\projects\cppformat\test\posix-mock-test.vcxproj]
         C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\stdlib.h(499): note: see previous definition of '_strtod_l'
@vitaut
Copy link
Contributor Author

vitaut commented Mar 18, 2016

Here are the declarations from locale.h (facepalm):

_Check_return_opt_
_ACRTIMP _locale_t __cdecl _create_locale(
    _In_   int         _Category,
    _In_z_ char const* _Locale
    );

_ACRTIMP void __cdecl _free_locale(
    _In_opt_ _locale_t _Locale
    );

@vitaut
Copy link
Contributor Author

vitaut commented Mar 19, 2016

Fixed in 9ffe98c.

@vitaut vitaut closed this as completed Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant