Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly misleading chrono extension documentation #3169

Closed
eli-b opened this issue Nov 8, 2022 · 2 comments
Closed

Slightly misleading chrono extension documentation #3169

eli-b opened this issue Nov 8, 2022 · 2 comments

Comments

@eli-b
Copy link

eli-b commented Nov 8, 2022

The Chrono Format Specifications section claims "the available presentation types ... for chrono durations and time points are" and then lists only 'H', 'M', and 'S'. This may lead the reader to believe the rest of the ~39 chrono_type characters only apply to std::tm, which I believe is incorrect.

Also, following #1866, the list of chrono presentation types should be expanded with a description for each type. If the types are meant to be the same as strftime's, this is not mentioned.

@vitaut
Copy link
Contributor

vitaut commented Nov 9, 2022

The docs have been updated: https://fmt.dev/dev/syntax.html#chrono-specs.

@vitaut vitaut closed this as completed Nov 9, 2022
@eli-b
Copy link
Author

eli-b commented Nov 9, 2022

Thanks, @vitaut, this is a great improvement to the docs! And so quick, too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants