Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thousands separator problem #529

Closed
w17 opened this issue Jun 28, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@w17
Copy link

commented Jun 28, 2017

I found some problems using library in farmanager project for {i:n} format.

  1. [Bug]
    Thousands separator is always char in library. It caused problem when separator is unicode character wider than 1 byte. It is very possible in windows case.

  2. [Feature request]
    For now there is no way to customize separator manually.
    In farmanager thousands separator is configurable [optional].
    Is it possible to pass that custom value to library?

There is link to discussion on farmanager bugtracker: http://bugs.farmanager.com/view.php?id=3382

@vitaut

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2017

Both issues are addressed in the new experimental version of the library. This version is located in the std branch and described in the standards proposal http://fmtlib.net/Text%20Formatting.html.

The first issue is solved by using C++ locales that support wide thousands separator character.

Thousands separator can be customized by passing a custom locale via a buffer.

@w17

This comment has been minimized.

Copy link
Author

commented Jul 1, 2017

Can that fatures arrive in the release?

@vitaut

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2017

Yes, these features/fixes will be a part of the next major release (since replacing C with C++ locales is a breaking change).

@vitaut

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

Fixed in the std branch.

@vitaut vitaut closed this Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.