Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4910 warning treated as error VS 2019 #1712

Closed
sunnlok opened this issue Jun 3, 2020 · 5 comments
Closed

C4910 warning treated as error VS 2019 #1712

sunnlok opened this issue Jun 3, 2020 · 5 comments

Comments

@sunnlok
Copy link

sunnlok commented Jun 3, 2020

I am getting
format.h(762,44):error C2220: the following warning is treated as an error format.h(762,44): warning C4910: 'fmt::v6::detail::basic_data<void>': '__declspec(dllexport)' and 'extern' are incompatible on an explicit instantiation
when trying to compile fmt via cmake.
No special options are set.

@vitaut
Copy link
Contributor

vitaut commented Jun 4, 2020

What library version do you use?

@sunnlok
Copy link
Author

sunnlok commented Jun 4, 2020

For fmt? I pulled from master.

@vitaut
Copy link
Contributor

vitaut commented Jun 4, 2020

Could you give a commit hash? master is a moving target.

@sunnlok
Copy link
Author

sunnlok commented Jun 4, 2020

that would be 16aec06
still present in the latest commit though

vitaut added a commit that referenced this issue Jun 5, 2020
@vitaut
Copy link
Contributor

vitaut commented Jun 5, 2020

The warning should be fixed in 795b47a. Thanks for reporting.

@vitaut vitaut closed this as completed Jun 5, 2020
vitaut added a commit that referenced this issue Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants