Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a deps.edn for Clojure command line users #49

Open
pmonks opened this issue Oct 30, 2018 · 8 comments
Open

Provide a deps.edn for Clojure command line users #49

pmonks opened this issue Oct 30, 2018 · 8 comments

Comments

@pmonks
Copy link
Contributor

pmonks commented Oct 30, 2018

It would be great if the project included a deps.edn file, so that users of the Clojure command line tools can evaluate the library.

@jolby
Copy link

jolby commented Nov 6, 2018

I've just tried using a deps.edn file (OSX, jdk 11, brew clojure 1.9.0.397), and it hangs. Looks like its getting stuck on resolving circular deps:
https://dev.clojure.org/jira/browse/TDEPS-79?focusedCommentId=50341&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel

@pmonks
Copy link
Contributor Author

pmonks commented Nov 6, 2018

Good catch @jolby! I added a comment regarding classifiers - that may be the issue we're seeing with hangs.

@pmonks pmonks added the blocked label Nov 6, 2018
@pmonks
Copy link
Contributor Author

pmonks commented Nov 6, 2018

Appears to be blocked on https://dev.clojure.org/jira/browse/TDEPS-79.

@zcaudate
Copy link
Contributor

zcaudate commented Nov 6, 2018

I don't understand. Can't the clj users just pull the library down from maven?

I haven't really tried clj so I don't know how it all works.

@pmonks
Copy link
Contributor Author

pmonks commented Nov 7, 2018

@zcaudate yeah that's how clj works, but right now tools.deps (which clj is the front end of) seems to have two bugs:

  1. it doesn't detect circular dependencies (so ends up spinlocking)
  2. it doesn't appear to be sensitive to classifiers, which (in the case of openjfx) means it ends up synthesising a circular dependency that shouldn't exist, thereby running afoul of the previous point

These are what TDEPS-79 is tracking.

@zcaudate
Copy link
Contributor

zcaudate commented Nov 7, 2018

Ah. Got it.

@jdf-id-au
Copy link

Java 8's fine in the meantime.

{:deps {fn-fx/fn-fx-javafx {:mvn/version "0.5.0-SNAPSHOT"}}} works as expected, using:

  • macOS 10.13.6
  • java 1.8.0_192 via brew cask install java8
  • clojure 1.9.0.391 also via brew

@MageMasher
Copy link

https://dev.clojure.org/jira/browse/TDEPS-79 is now resolved. I can confirm deps now works with the latest version of tools.deps

@pmonks pmonks removed the blocked label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants