Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for TYPO3 11 #5

Closed
criwe opened this issue Jan 14, 2022 · 7 comments
Closed

Release for TYPO3 11 #5

criwe opened this issue Jan 14, 2022 · 7 comments

Comments

@criwe
Copy link

criwe commented Jan 14, 2022

Hi,
is an release for TYPO3 11 planed?
Thanks!
Regards,
Christoph

@fnagel fnagel changed the title Release for 11 Release for TYPO3 11 Jan 14, 2022
@fnagel
Copy link
Owner

fnagel commented Jan 14, 2022

Yes, there is already an adjusted branch, see https://github.com/fnagel/fe_performance/tree/typo3-11

I did not have the time / project to test every feature for a final release. Any feedback is very welcome!

@criwe
Copy link
Author

criwe commented Jan 14, 2022

Thanks!
Well, a first brief test did´t do well -> JS crashed, no html-code-minification.
If you want to have a look, we can have a call later or next week.
Best,
Christoph

@fnagel
Copy link
Owner

fnagel commented Jan 14, 2022

Regarding crashing JS I need more info. There haven't been much changes at all: https://github.com/fnagel/fe_performance/compare/typo3-11

HTML minification has been removed, see 0ef8949

Reasons: 1) underlying TYPO3 functionality has changed and it's unclear how to migrate this 2) the implementation with regex always had its issues 3) Using GZIP compression is widely available and should do a better job in general
Anyway, if you find a way to do this in TYPO3 11 I would consider re-add it.

We can do a call later today...

@criwe
Copy link
Author

criwe commented Jan 14, 2022

Ok, thanks for the call.

What we found out: reason was minifying of allready minifed files.

Regards,
Christoph

@criwe criwe closed this as completed Jan 14, 2022
@fnagel
Copy link
Owner

fnagel commented Jan 14, 2022

Let's keep this open as the final release needs to be done...

@fnagel fnagel reopened this Jan 14, 2022
@fnagel
Copy link
Owner

fnagel commented Apr 29, 2022

Just released version 2.0.0 with TYPO3 11 support.

@criwe FYI (...and HTML minify is back again using a middleware!)

@fnagel fnagel closed this as completed Apr 29, 2022
@criwe
Copy link
Author

criwe commented Jan 14, 2023

@fnagel A little late: but thank you and it is already running successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants