Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on #browser_version #222

Closed
brauliobo opened this issue Mar 16, 2016 · 3 comments
Closed

Crash on #browser_version #222

brauliobo opened this issue Mar 16, 2016 · 3 comments

Comments

@brauliobo
Copy link

wrong number of arguments (2 for 1) on line 18 of lib/browser/generic.rb

    def full_version
      ua[%r[(?:QuickTime)/([\d.]+)], 1] ||
        ua[%r[CoreMedia v([\d.]+)], 1] ||
        "0.0"
    end
@brauliobo brauliobo changed the title Crash on #browser_version Crash on #browser_version Mar 16, 2016
@fnando
Copy link
Owner

fnando commented Mar 16, 2016

Can you please fulfill the ticket information with all required info?

https://raw.githubusercontent.com/fnando/browser/master/.github/ISSUE_TEMPLATE.md

@brauliobo
Copy link
Author

sorry, the problem was that it was recreating the browser instance like this: @browser ||= Browser.new(ua: request.user_agent)

@bbuchalter
Copy link

For others affected by this error, my issue was an obsolete and unspecified dependency browsernizer had on this gem for version 1. See assembler/browsernizer#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants