Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests #53

Closed
2 tasks
rdallman opened this issue Jul 27, 2017 · 8 comments
Closed
2 tasks

Broken tests #53

rdallman opened this issue Jul 27, 2017 · 8 comments
Assignees

Comments

@rdallman
Copy link
Contributor

In gitlab by @denismakogon on May 30, 2017, 03:44

This issue opened to track work being done for fixing tests. Test report attached.
fn_tests.report

Tasks:

  • Update image to fix assertion in tests
  • Fix LB tests
@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 03:44

changed the description

@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 04:11

assigned to @treeder

@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 04:14

@treeder would you mind to update image treeder/hello because it makes test to fail. See more info in test report.

Here's small test to verify that image does not act normally (according to tests expectation):

echo '{"name": "test"}' | docker run -i --rm --name test-travis treeder/hello

expected output:

Hello test!

got instead:

Hello World!

@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 04:22

changed the description

@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 04:31

mentioned in issue #16

@rdallman
Copy link
Contributor Author

In gitlab by @denismakogon on May 30, 2017, 07:55

mentioned in merge request !29

@rdallman
Copy link
Contributor Author

In gitlab by @hibooboo2 on May 30, 2017, 08:50

closed via commit 2518898

@rdallman
Copy link
Contributor Author

In gitlab by @hibooboo2 on May 30, 2017, 08:50

closed via merge request !29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants