Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Unify colors for 'Repeat' and 'Conditional' statements #50

Closed
mxt3 opened this issue Jan 3, 2022 · 1 comment · Fixed by #52
Closed

[Feature request] Unify colors for 'Repeat' and 'Conditional' statements #50

mxt3 opened this issue Jan 3, 2022 · 1 comment · Fixed by #52

Comments

@mxt3
Copy link

mxt3 commented Jan 3, 2022

Is your feature request related to a problem? Please describe.

A conditional statement and loop statement are currently highlighted differently in the base16 vim themes. This seems against the base16 philosophy. I quote from the spec (https://github.com/chriskempson/base16/blob/master/styling.md):

Base16 aims to group similar language constructs with a single color.

The cause of this are the following lines in the template file:

call <sid>hi("Conditional",  s:gui0E, "", s:cterm0E, "", "", "")
" ...
call <sid>hi("Repeat",       s:gui0A, "", s:cterm0A, "", "", "")

The two groups seem to have been intentionally assigned different colors, yet they are very related. Is there a reasoning behind this? The VS Code base16 themes to no have this difference.

Describe the solution you'd like

Assign the same color to the Repeat and Conditional statement keywords.

Describe alternatives you've considered

N.A.

Additional context

Here is an example of a .cpp snippet highlighted with base16-ashes in vim:

Here is the same base16 theme in Visual Studio Code:

The while and if keywords have the same color in VS code, as I would expect from the philosophy.

@GordianDziwis
Copy link
Contributor

Good catch! The syntax highlights are a bit WIP because of the treesitter and lsp semantic token stuff. So if you see other inconsistencies, please report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants