You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, @enebo pointed me to your README where you mention JRuby failing the build because of refinements. I've been working in getting refinements working better, so I figured I'd see if xorcist works better on JRuby master (which will be 9.2.7):
[] ~/projects/xorcist $ bundle exec rake
Run options: --seed 8423
# Running:
........
Fabulous run in 0.021027s, 380.4612 runs/s, 903.5954 assertions/s.
8 runs, 19 assertions, 0 failures, 0 errors, 0 skips
[] ~/projects/xorcist $ jruby -v
jruby 9.2.7.0-SNAPSHOT (2.5.3) 2019-03-05 2c4518f OpenJDK 64-Bit Server VM 25.202-b08 on 1.8.0_202-b08 +jit [darwin-x86_64]
So you should be good to go using refinements on JRuby 9.2.7 or higher. If you decide to keep the refinements, do update the README to mention that requirement.
Thank you!
The text was updated successfully, but these errors were encountered:
Also, I've tested JRuby 9.2.7 on my computer, and all tests pass. I'm battling with a Travis CI issue now where JRuby 9.2.7 has difficulty being installed.
Hey, @enebo pointed me to your README where you mention JRuby failing the build because of refinements. I've been working in getting refinements working better, so I figured I'd see if xorcist works better on JRuby master (which will be 9.2.7):
So you should be good to go using refinements on JRuby 9.2.7 or higher. If you decide to keep the refinements, do update the README to mention that requirement.
Thank you!
The text was updated successfully, but these errors were encountered: