Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend JRuby 9.2.7 if you keep refinements #7

Closed
headius opened this issue Mar 6, 2019 · 3 comments
Closed

Recommend JRuby 9.2.7 if you keep refinements #7

headius opened this issue Mar 6, 2019 · 3 comments

Comments

@headius
Copy link

headius commented Mar 6, 2019

Hey, @enebo pointed me to your README where you mention JRuby failing the build because of refinements. I've been working in getting refinements working better, so I figured I'd see if xorcist works better on JRuby master (which will be 9.2.7):

[] ~/projects/xorcist $ bundle exec rake
Run options: --seed 8423

# Running:

........

Fabulous run in 0.021027s, 380.4612 runs/s, 903.5954 assertions/s.

8 runs, 19 assertions, 0 failures, 0 errors, 0 skips

[] ~/projects/xorcist $ jruby -v
jruby 9.2.7.0-SNAPSHOT (2.5.3) 2019-03-05 2c4518f OpenJDK 64-Bit Server VM 25.202-b08 on 1.8.0_202-b08 +jit [darwin-x86_64]

So you should be good to go using refinements on JRuby 9.2.7 or higher. If you decide to keep the refinements, do update the README to mention that requirement.

Thank you!

@fny
Copy link
Owner

fny commented Mar 29, 2019

Thanks for the update! I just added it to the Travis suite for whenever the release is cut. Do you hav a time frame when I should look back?

Travis is also screaming about some issues with an older version of bundler that I'll need to sift through as well.

@enebo
Copy link

enebo commented Mar 29, 2019

@fny we should be releasing 9.2.7.0 next week barring any snags.

@fny fny closed this as completed Jul 15, 2019
@fny
Copy link
Owner

fny commented Jul 24, 2019

Hey all, just an update.

I've decided to keep refinements since it looks like others in the community are already using them: https://github.com/swisscom/ruby-netsnmp

Also, I've tested JRuby 9.2.7 on my computer, and all tests pass. I'm battling with a Travis CI issue now where JRuby 9.2.7 has difficulty being installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants