Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the train/test split #19

Closed
hxwork opened this issue Aug 29, 2022 · 2 comments
Closed

Question about the train/test split #19

hxwork opened this issue Aug 29, 2022 · 2 comments

Comments

@hxwork
Copy link

hxwork commented Aug 29, 2022

Dear authors,

Thanks for opening source your code, and it is really helpful. I have a question about the train/test split of the Laval HDR dataset when I read the paper. It says that 19,556 training pairs are generated from 2,100 HDR panoramas, and 200 images are randomly selected as the test set. I am not sure if the 200 images are selected from the 2,100 HDR panoramas, or just from the 19,556 generated images. If they are from the 19,556 images, how to make sure the corresponding HDR panoramas of them are not in the training set or not seen during the training process?

Best regards,
Hao XU

@fnzhan
Copy link
Owner

fnzhan commented Aug 30, 2022

Hi Hao Xu, as there is no common split of training/testing set for Laval HDR, I just randomly select 200 images from 19,556 training pairs. Thus, the test images and training images may be the same 3D scene but in different views. Of course, selecting test scenes from 2,100 HDR panoramas will be better for accurate evaluation.

@hxwork
Copy link
Author

hxwork commented Aug 30, 2022

Got it. Thanks for your rapid reply.

@hxwork hxwork closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants