Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Usage of AdvancedDicomClient correct? #1641

Closed
ayedo opened this issue Aug 14, 2023 · 1 comment
Closed

Documentation: Usage of AdvancedDicomClient correct? #1641

ayedo opened this issue Aug 14, 2023 · 1 comment
Labels

Comments

@ayedo
Copy link

ayedo commented Aug 14, 2023

In the README the following usgage of the AdvancedDicomClient is shown:

image

Why is there a using on the Association but also in the finally block ReleaseAsync is called? Why not release all resources already in the dispose call?

Thanks and best,

Alon

@ayedo ayedo added the new label Aug 14, 2023
@ayedo ayedo closed this as completed Aug 16, 2023
@gofal gofal added question and removed new labels Aug 18, 2023
@gofal
Copy link
Contributor

gofal commented Aug 18, 2023

This is, because the "ReleaseAsync" is not an internal cleanup of objects, as the disposing is, but the "ReleaseAsync" is a DICOM-action where an AssociationReleaseRequest is sent via network and then a AssociationReleaseResponse is expected. This is rather a very certain SendReqeustAsync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants