Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed foam.openDailyNote.directory does not create daily notes in the correct location with multiple (named) workspace folders #1126

Closed
djagoo opened this issue Dec 24, 2022 · 0 comments · Fixed by #1175
Labels
bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode
Milestone

Comments

@djagoo
Copy link

djagoo commented Dec 24, 2022

    So I think I found a good solution for this issue, and I have committed it. It will come out with the 0.20.1

Originally posted by @riccardoferretti in #1073 (comment)

This solved it for multiple workspace folders. But it still happens for me when I change the "name" value of a workspace folder e.g. to "my notes" instead of "notes" like in the path value it creates a "my notes/journal/" subfolder in notes.

{
  "folders": [
    {
      "name": "test of folder1",
      "path": "./folder1"
    },
    {
      "name": "test of folder2",
      "path": "./folder2"
    }
  ],
  "settings": {
    "foam.openDailyNote.directory": "journal"
  },
  "extensions": {
    "recommendations": [
      "foam.foam-vscode"
    ]		]
  }
}

creates:

./folder1/test of folder1/2022-12-24.md


"foam.openDailyNote.directory": "./folder1/journal"

creates

./folder1/test of folder1/folder1/journal/2022-12-24.md


"foam.openDailyNote.directory": "~/tmp/folder1/journal"

creates

./folder1/test of folder1/~/tmp/folder1/journal/2022-12-24.md


Changing "name": "test of folder1", to "name": "folder1" resolves the issue for the moment.

@riccardoferretti riccardoferretti added this to the backlog milestone Feb 26, 2023
@riccardoferretti riccardoferretti added bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode labels Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants