Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link references being published to GitHub Pages? #51

Closed
caseyg opened this issue Jul 4, 2020 · 2 comments
Closed

Broken link references being published to GitHub Pages? #51

caseyg opened this issue Jul 4, 2020 · 2 comments

Comments

@caseyg
Copy link

caseyg commented Jul 4, 2020

Any idea why my link references are getting committed and published to GitHub Pages? Aren't they supposed to only appear in VS Code for now?

(p.s. Foam is amazing!! Thank you.)

GitHub Pages:

Screenshot 2020-07-04 at 7 56 38 AM

VS Code:

Screenshot 2020-07-04 at 7 56 53 AM

Web:
https://cag.wiki/todo

Github:
https://github.com/caseyg/foam/blob/master/todo.md

@caseyg caseyg changed the title [Broken] Link references being published to GitHub Pages? Broken link references being published to GitHub Pages? Jul 4, 2020
@jevakallio
Copy link
Collaborator

jevakallio commented Jul 4, 2020

I am no longer seeing these in the live site so looks like you got it fixed @caseyg!

The issue was that there was no new line between the last line of content and link reference definition list in this commit:
https://github.com/caseyg/foam/commit/33f8e3fbacda6241706e6823aa85de7be9c142a5#diff-5b51c9e8380c18fc2ee8d866662d01d8

Markdown specifically requires a new line.

However, I'm not sure how this occurred, as the foam-vscode plugin is supposed to ensure the newline is added. Could you give me the version of the extension you're using -- I have made fixes in this area in the past week, but if you downloaded today and are on 0.1.6+ this should not be an issue and needs to be investigated.

@jevakallio
Copy link
Collaborator

I couldn't replicate this issue, so going to assume that either this happened on old version of foam-vscode, or the update task didn't run at all.

Closing to clean up issues, please reopen if the issue persists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants